[feat][DTC-5411] updated jobs runner to be able to use temporal #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avimoondra
requested changes
Oct 16, 2023
docker-compose.yml
Outdated
Comment on lines
14
to
16
| - WORKFLOW_TEMPORAL_CLUSTER_FRONTEND_HOST=temporal | ||
| - WORKFLOW_TEMPORAL_CLUSTER_FRONTEND_PORT=7233 | ||
| - WORKFLOW_BACKEND_HOST=http://api:3000 |
There was a problem hiding this comment.
why is this included here? i think the comments from L17 to L25 should be pasted into the jobs-runner service definition?
There was a problem hiding this comment.
and then jobs-runner should also be part of workflows network?
alex-stabile
requested changes
Oct 18, 2023
There was a problem hiding this comment.
Why are we making these changes? I think we need to align with the rest of DTC on what the plan is here and why we're making these changes.
I also don't think we should "convert" jobs runner into a temporal worker. I like @roberto-retool 's suggestion here about adding source control to the temporal worker.
I don't see why we would update the public on-premise repo until we've validated our new setup with a customer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating env vars for retool onpremise to allow jobs runner to access temporal and turn into a internal onprem temporal worker.
https://linear.app/retool/issue/DTC-5411/update-docker-images-with-new-jobs-runner-env-vars